Replace from torch.nn.functional import ... with import torch.nn.functional as F#89
Open
kalekundert wants to merge 1 commit intoQUVA-Lab:masterfrom
Open
Replace from torch.nn.functional import ... with import torch.nn.functional as F#89kalekundert wants to merge 1 commit intoQUVA-Lab:masterfrom
from torch.nn.functional import ... with import torch.nn.functional as F#89kalekundert wants to merge 1 commit intoQUVA-Lab:masterfrom
Conversation
…unctional as F` These two expressions are almost identical, but it turns out that the latter is (currently) necessary to visualize models using torchlens. See johnmarktaylor91/torchlens#18. While this is a pretty minor benefit, it's also a pretty minor change. Signed-off-by: Kale Kundert <kale@thekunderts.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These two expressions are almost identical, but it turns out that the latter is (currently) necessary to visualize models using torchlens. See johnmarktaylor91/torchlens#18 for more information. While this is a pretty minor benefit, it's also a pretty minor change.