Skip to content

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Oct 2, 2023

Bumps github.com/tendermint/tendermint from 0.32.7 to 0.32.10.

Release notes

Sourced from github.com/tendermint/tendermint's releases.

v0.32.10 (WARNING: ALPHA SOFTWARE)

https://github.com/tendermint/tendermint/blob/v0.32.x/CHANGELOG.md#v03210

v0.32.9 (WARNING: ALPHA SOFTWARE)

https://github.com/tendermint/tendermint/blob/v0.32.x/CHANGELOG.md#v0329

v0.32.8 (WARNING: ALPHA SOFTWARE)

https://github.com/tendermint/tendermint/blob/v0.32.x/CHANGELOG.md#v0328

Changelog

Sourced from github.com/tendermint/tendermint's changelog.

v0.32.10

April 6, 2020

This security release fixes:

Denial of Service 1

Tendermint 0.33.2 and earlier does not limit the number of P2P connection requests. For each p2p connection, Tendermint allocates ~0.5MB. Even though this memory is garbage collected once the connection is terminated (due to duplicate IP or reaching a maximum number of inbound peers), temporary memory spikes can lead to OOM (Out-Of-Memory) exceptions.

Tendermint 0.33.3 (and 0.32.10) limits the total number of P2P incoming connection requests to to p2p.max_num_inbound_peers + len(p2p.unconditional_peer_ids).

Notes:

  • Tendermint does not rate limit P2P connection requests per IP (an attacker can saturate all the inbound slots);
  • Tendermint does not rate limit HTTP(S) requests. If you expose any RPC endpoints to the public, please make sure to put in place some protection (https://www.nginx.com/blog/rate-limiting-nginx/). We may implement this in the future (#1696).

Denial of Service 2

Tendermint 0.33.2 and earlier does not reclaim activeID of a peer after it's removed in Mempool reactor. This does not happen all the time. It only happens when a connection fails (for any reason) before the Peer is created and added to all reactors. RemovePeer is therefore called before AddPeer, which leads to always growing memory (activeIDs map). The activeIDs map has a maximum size of 65535 and the node will panic if this map reaches the maximum. An attacker can create a lot of connection attempts (exploiting Denial of Service 1), which ultimately will lead to the node panicking.

Tendermint 0.33.3 (and 0.32.10) claims activeID for a peer in InitPeer, which is executed before MConnection is started.

Notes:

  • InitPeer function was added to all reactors to combat a similar issue - #3338;
  • Denial of Service 2 is independent of Denial of Service 1 and can be executed without it.

All clients are recommended to upgrade

... (truncated)

Commits
  • eab4d6d Merge pull request from GHSA-v24h-pjjv-mcp6
  • cf114c9 UnconditionalPeerIDs do not exist in v0.32
  • 49d8c0b changelog: fix grammar
  • 63c9384 update changelog and version
  • 0a1ef4a p2p: limit the number of incoming connections
  • ffb0278 mempool: reserve IDs in InitPeer instead of AddPeer
  • e6a7757 release: changelog & version (#4298)
  • 51ccaf6 metrics: add metrics for specific validators (#4294)
  • be771f2 rpc/lib: RPC client basic authentication with URL parsing refactored (#4285)
  • aad59f2 rpc/lib: fix RPC client, which was previously resolving https protocol to htt...
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [github.com/tendermint/tendermint](https://github.com/tendermint/tendermint) from 0.32.7 to 0.32.10.
- [Release notes](https://github.com/tendermint/tendermint/releases)
- [Changelog](https://github.com/tendermint/tendermint/blob/main/CHANGELOG.md)
- [Commits](tendermint/tendermint@v0.32.7...v0.32.10)

---
updated-dependencies:
- dependency-name: github.com/tendermint/tendermint
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from kauchy as a code owner October 2, 2023 12:28
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants