pin clang and gcc versions for ubuntu22-openmpi #4696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prckent
previously approved these changes
Aug 10, 2023
ye-luo
reviewed
Aug 10, 2023
| apt-get install gcc g++ \ | ||
| clang \ | ||
| apt-get install gcc-9 g++-9 \ | ||
| clang-14 \ |
There was a problem hiding this comment.
After this, do gcc and g++ automatically point to 9 and does clang point to 14?
I'm asking this because I vaguely remember this only produce gcc-9/clang-14 but no gcc/clang.
There was a problem hiding this comment.
Since we are doing versioned install, please do clang-format-14 clang-tidy-14 and libomp-14-dev as they are from llvm
There was a problem hiding this comment.
these lines swap the defaults to the new versions
|
Please push the image and use this PR to see if the image update works as intended. |
@ye-luo the image has been pushed and I reran the tests, under the configure step you should see: |
|
Test this please |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the developer documentation
on the wiki of this project that contains help and requirements.
Proposed changes
This is updating the dockerfile for the changes I'm about to push for the
ubuntu22-openmpi:latestimage.GCC9 tests have not been using gcc9, this should set gcc9 as the default and thus fix this.
In addition, I've also done this for clang just in case.
What type(s) of changes does this code introduce?
Delete the items that do not apply
Does this introduce a breaking change?
What systems has this change been tested on?
Checklist
Update the following with a yes where the items apply. If you're unsure about any of them, don't hesitate to ask. This is
simply a reminder of what we are going to look for before merging your code.