-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support QE v6.7.0 #2927
Support QE v6.7.0 #2927
Conversation
Can one of the admins verify this patch? |
Thanks Kevin! What was the issue causing the problems with some of the tests in your previous PR? (Something we should remember for future patches of new QE versions.) |
The filenames were not consistent in cases where pw2qmcpack split the data among multiple hdf5 files (there were extra leading spaces before the part index, so data was being written to |
Thanks. I was more fearful of a symmetry problem. Happily that was not the case. I am currently building and testing this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed working. Ran the qe workflow tests with both real and complex builds.
Test this please |
Okay to test |
Test this please |
Proposed changes
adds a new patch for the latest version of QE. Closes #2230
This patches the official v6.7.0 release to be up-to-date with the release on Ye's fork.
What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
Checklist