Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support QE v6.7.0 #2927

Merged
merged 2 commits into from
Feb 17, 2021
Merged

Support QE v6.7.0 #2927

merged 2 commits into from
Feb 17, 2021

Conversation

kgasperich
Copy link
Contributor

@kgasperich kgasperich commented Feb 16, 2021

Proposed changes

adds a new patch for the latest version of QE. Closes #2230
This patches the official v6.7.0 release to be up-to-date with the release on Ye's fork.

What type(s) of changes does this code introduce?

  • new converter patch for latest version of QE

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

  • ALCF Cooley (built with mvapich 2.3.4, gcc 7.1.0)

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'
  • No. Code added or changed in the PR has been clang-formatted (just a diff and a bash script)
  • No. This PR adds tests to cover any new code, or to catch a bug that is being fixed
  • No. Documentation has been added (if appropriate)

@qmc-robot
Copy link

Can one of the admins verify this patch?

@prckent
Copy link
Contributor

prckent commented Feb 16, 2021

Thanks Kevin! What was the issue causing the problems with some of the tests in your previous PR? (Something we should remember for future patches of new QE versions.)

@kgasperich
Copy link
Contributor Author

The filenames were not consistent in cases where pw2qmcpack split the data among multiple hdf5 files (there were extra leading spaces before the part index, so data was being written to *.pwscf.h5_part 1 instead of *.pwscf.h5_part1), but the function that read these parts to combine them into a single file for qmcpack did not have the extra spaces in the filename.

@prckent
Copy link
Contributor

prckent commented Feb 16, 2021

Thanks. I was more fearful of a symmetry problem. Happily that was not the case.

I am currently building and testing this PR.

@prckent prckent changed the title patch for QE v6.7.0 Support QE v6.7.0 Feb 16, 2021
@prckent prckent self-requested a review February 17, 2021 00:07
Copy link
Contributor

@prckent prckent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working. Ran the qe workflow tests with both real and complex builds.

@prckent
Copy link
Contributor

prckent commented Feb 17, 2021

Test this please

@ye-luo
Copy link
Contributor

ye-luo commented Feb 17, 2021

Okay to test

@ye-luo
Copy link
Contributor

ye-luo commented Feb 17, 2021

Test this please

@ye-luo ye-luo merged commit b20341f into QMCPACK:develop Feb 17, 2021
@prckent prckent added this to the v3.11.0 milestone Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QE 6.5 support
4 participants