-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Important modifications to be applied the presentation of Workshop 8 #4
Comments
Working on splitting the theoretical part and improving the mathematical explanations (#11), I noticed a couple of other aspects that would be important to fix:
EDIT:
|
And in reply to the description of the issue: I think EDF is actually a shorthand for "effective degrees of freedom" (rather than "estimated", see Wood, 2017). This is already addressed by #11 |
As to "Figures generated within section "7. Quick intro to GAMM" should be within the same slides as their code" Since each pair of plots requires 7 lines of code, it was difficult to put the plots on the same slide while keeping them large enough. So I think it's actually a good idea to keep them separated for now. This whole section is likely to improve once changed to a real-world data set (see #17), where fewer plots may be necessary to show what's going on. |
Merging @dschoenig commits related to #4, #1, and extra examples.
Before developing and modifying this workshop, please read through the presenter and developer protocol carefully and refer back to it regularly as you work.
General issues to be addressed related to the presentation of this workshop
[Priority] Specific to adapting workshops to a remote framework:
instruction: hidden_remote
tag. See an example below:Specific to slide structure, grammar and style
Ensure code is working correctly and that code matches workshop presentation. Continue to check this as you make changes.
Proofread correcting spelling, grammar, or punctuation errors.
Look for and correct the content of slides that overflow the screen.
Look for and correct prose that mentions function names, object names, package names and code chunks that do not use backticks.
Look for and correct unnecessary abbreviations (e.g. use do not instead of don’t).
Correct unnecessary long sentences.
Ensure that the slides are written in a consistent style, which helps with the flow of workshops and student understanding. This is especially important when working collaboratively with other developers.
Include presenter notes to the slides you modify. You can write notes for yourself to read in the presenter mode (press the keyboard shortcut
p
). These notes are written under three question marks???
. See the example below:Specific to the translation of this workshop
Add and translate the modified content to the French version of the workshop.
Proofread and correct spelling, grammar and punctuation errors.
Correct unnecessary long sentences.
General comments
This workshop offers a very good (and ambitious) summary to those interested in generalized additive modelling techniques. While it is an advanced workshop and most participants taking it are assumed to have some knowledge of general linear models and generalized linear models, this workshop would benefit a lot from more mathematical explanations to some of its procedures (especially at its beginning and on those indicated when expanding the basic GAM). There is a useful explanation within section 8 (GAM behind the scenes), which would be best if it came before or incrementally during the presentation to reduce the level of abstraction for participants.
In addition to a push on the mathematical explanation of additive models, this workshop could also benefit from more biological examples (it is mostly done on simulated data).
In addition to the resources available within the presentation, the article Hierarchical generalized additive models
in ecology: an introduction with mgcv from Pedersen et al. 2019 has a great review and various examples on generalized additive models.
Separate larger issues to be solved
Specific issues to be solved
y_obs ~ s(x)
instead ofy_obs~s(x)
andy_obs ~ s(x) + x
instead ofy_obs~s(x)+x
;basic_summary$p.table
andbasic_summary$s.table
(and their outputs) in different code chunks and output blocks preceded by their explanation;edf
on Slide 31;plot(basic_model)
on Slide 32 (GAM with multiple variables);two_term_summary$p.table
andtwo_term_summary$s.table
(and their outputs) in different code chunks and output blocks preceded by their explanation (as recommended above). Do the same on Slide 35.Model 3
using#<<
;prop_summary$p.table
andprop_summary$s.table
(and their outputs) in different incremental code chunks and output blocks preceded by the questions (this is a good opportunity for the presenter to interact with participants since this output has been shown several times during this workshop);Checkout
The text was updated successfully, but these errors were encountered: