-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filesystem refactor and update #419
Filesystem refactor and update #419
Conversation
…740g/QB64pe into filesystem-refactor-and-update
I'm not so certain about the _FQN name. Honestly, I don't think it's a set of abbreviations that's going to mean a whole lot to the old foggies who tend to program in BASIC a lot. As much as I hate extra typing, I'd think a more verbose name might be needed here to maintain the general style as BASIC programming. Perhaps something like _FULLPATH. Or could these two functions somehow be combined into one? _FILES$ (filespec$ , "verbose|brief") Being picky over a command name seems almost petty in many ways, but this is very useful functionality. You want to try and make it as intuitive for the general user as possible, when you add it into the language. |
(Even if it is kept as a short command name, shouldn't it at least be _FQFN for a Fully Qualified File Name? ) |
BASIC itself is not consistent with names. 😁 FRE, MK* and CV* are some that comes to mind. But I too am with you on verbose names. I initially thought of I'll change |
Well, it works for both file names and directory names. So, I not sure if we should use |
_FULLPATH sounds good to me, unless anyone else has a better suggestion. Otherwise, from what I can tell looking over this, it all looks good to me. :) |
Closes #34
Closes #148
This pull request represents a significant refactoring effort to consolidate all filesystem-related APIs into their own translation unit inside
libqb/
. It now correctly handles all APIs, including some that were previously only implemented for Windows, across all supported platforms. This also auto-corrects directory separators infunc__loadimage()
,sub__saveimage()
,func__sndopen()
andfunc__loadfont()
.The following two new functions were added: