Improve validation for sibling pages security #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket:
Description of changes
In the past, if you had a parent page with that was not published, and you've added children to it, you weren't able to publish it anymore, due to the validation. This is now fixed. You are now able to publish parent pages that have not been published before. After the page has been published, you can't change the slug anymore if it has children. This is how it should work.
How to validate the changes
Tobias and I tested this in the British Library project.
✅ Definition of Done
This checklist helps with risk management during software development. It is not a mandatory list to fully check off, but a basis for thinking about quality, safety, and best practices. Feel free to adapt it for your own project — as long as the risks are consciously managed.
📄 Documentation & Knowledge Sharing
README.md
🧪 Testing & Quality
📊 Monitoring & Performance
🔐 Security & Privacy
🧩 Traceability & Readiness
[R2025-1234] Meaningful title
)TODO
s remain in the code (unless followed up with a Jira ticket)🤝 Review & Collaboration