Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework GitHub Actions to correctly and sanely push to PyPi in a controlled manner #456

Merged
merged 7 commits into from
Jun 24, 2024

Conversation

AbstractUmbra
Copy link
Contributor

Description

This PR reworks the current build and publish actions, removing the latter and incorporating it into the former in a conditional branch.

NOTE
Due to how GitHub actions works, especially with this kind of release manipulation, there is no "testing" we can do. It will be a testing-in-production situation. I'll leave this in a draft state until @EvieePy (who owns TwitchIO on PyPi) and myself are on hand to triage and correct if issues arise.

The changes will now:

  • Build wheels for common architectures.
  • Build an sdist.
  • Publish all of the above to PyPi using it's OID Connection workflow, removing the need for user based tokens.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
    • I have updated the changelog with a quick recap of my changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)
  • I have read and agree to the Developer Certificate of Origin for this contribution

@AbstractUmbra AbstractUmbra marked this pull request as ready for review June 24, 2024 16:51
@AbstractUmbra AbstractUmbra merged commit b04c867 into master Jun 24, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants