Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[commands] Update docs to include proper walkthrough #426

Merged
merged 19 commits into from
Sep 19, 2023

Conversation

IAmTomahawkx
Copy link
Member

Pull request summary

This PR creates proper documentation for the commands ext, including a proper walkthrough and explanation of creating commands and parser capabilities.

Additionally, this fixes a bug where the PartialChatter converter depended on the chatter cache.

This PR requires #425

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
    • I have updated the changelog with a quick recap of my changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR contains non-code changes (e.g. documentation, README, ...)

@IAmTomahawkx IAmTomahawkx added 2.0 TwitchIO 2.0 EXT: commands Documentation Documentation related changes. labels Sep 4, 2023
@IAmTomahawkx IAmTomahawkx self-assigned this Sep 4, 2023
docs/exts/commands.rst Outdated Show resolved Hide resolved
@spofdamon
Copy link

This is really helpful, thanks.

@chillymosh
Copy link
Collaborator

LGTM other than
would reformat /home/runner/work/TwitchIO/TwitchIO/twitchio/ext/eventsub/models.py

@IAmTomahawkx IAmTomahawkx merged commit e51c270 into master Sep 19, 2023
10 checks passed
@IAmTomahawkx IAmTomahawkx deleted the feature/commands_docs branch September 19, 2023 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0 TwitchIO 2.0 Documentation Documentation related changes. EXT: commands
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants