-
-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sounds setters #395
Closed
sockheadrps
wants to merge
12
commits into
PythonistaGuild:maintain/2.x
from
sockheadrps:sounds_setters
Closed
Sounds setters #395
sockheadrps
wants to merge
12
commits into
PythonistaGuild:maintain/2.x
from
sockheadrps:sounds_setters
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for automatic detetction of local audio files' sample rate and audio channels so the files play correctly
@sockheadrps sorry for the late response, I kind of forgot to check prs. |
…om audio files. Added setters for rate and channel to expose them incase the meta data is incorrect.
…om audio files. Added setters for rate and channel to expose them incase the meta data is incorrect.
sockheadrps
force-pushed
the
sounds_setters
branch
from
June 18, 2024 07:12
28bc5f7
to
1f12f4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
edit:
Added TinyTag as a dependency to detect audio file meta data for channels and rate to auto set those values.
TinyTag is MIT and has no external dependencies of its own
Pull request summary
This could be a solution to #358
The sample rate of audio for Sound is hard coded (it might have something to do with YTDL, Im not sure), however if you create a sound using a local file
it's possible and likely to have files with different sample rates. Ive personally run into this issue and have seen others run into it as well, and the only solution right now is to hack at the library code to change the sample rate manually.
This PR just gives Sound.rate and Sound.channels a setter on each class property. Maybe in the future I can look at pulling sample meta data from the suppled audio file, but sometimes that can even be wrong so those class properties kind of need to be able to be set.
Checklist