feat: Better comments section #366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #366 +/- ##
==========================================
+ Coverage 80.12% 80.20% +0.08%
==========================================
Files 63 63
Lines 2953 2996 +43
==========================================
+ Hits 2366 2403 +37
- Misses 587 593 +6 ☔ View full report in Codecov by Sentry. |
yammesicka
commented
Feb 26, 2024
This was referenced Feb 28, 2024
fix: Erlang cookie might be a dir: add rm -r
fix!: linter email problem
dev(comment): Added field to `Comment._by_file`
refactor(comment): `comment.delete` now gets id as a parameter, instead
of using the `request` object.
fix: Better indication of errors on /comment endpoint
feat: Comments now also show user's gravatar
fix: Responsibility issues
KNOWN BUG: Adding a new comment looks strange.
KNOWN BUG: No migration for changing linter mail.
KNOWN BUG: There is an edit button -- it doesn't work ATM.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| const editButton = this.shadowRoot.querySelector('.edit-btn'); | ||
| const commentId = this.getAttribute('data-comment-id'); | ||
| editButton.addEventListener('click', () => { | ||
| window.location.href = `/comments/${commentId}/edit`; |
Check warning
Code scanning / CodeQL
DOM text reinterpreted as HTML
This was
linked to
issues
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
/comments?act=fetch&fileId=IDlogic to support avatarsEditing will follow the creation of the new md editor for adding new comments