Skip to content

Conversation

@sagizaidor
Copy link
Contributor

feat: Basic responsive calender day view page
Added dayview template with css and router.
An tempreroy event class with,
processing function for the day view to work.
fixed after taking notes, and lint

sagizaidor and others added 11 commits January 16, 2021 12:36
Added dayview template with css and router.
An tempreroy event class with,
 processing function for the day view to work.
Added dayview template with css and router.
An tempreroy event class with,
 processing function for the day view to work.
fixed after taking notes.
@yammesicka yammesicka closed this Jan 21, 2021
@yammesicka yammesicka deleted the branch PythonFreeCourse:develop January 21, 2021 02:36
@yammesicka yammesicka reopened this Jan 21, 2021
@codecov-io
Copy link

codecov-io commented Jan 21, 2021

Codecov Report

Merging #93 (7a64596) into develop (ab45a02) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop       #93    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           15        17     +2     
  Lines          425       628   +203     
==========================================
+ Hits           425       628   +203     
Impacted Files Coverage Δ
app/database/models.py 100.00% <100.00%> (ø)
app/main.py 100.00% <100.00%> (ø)
app/routers/dayview.py 100.00% <100.00%> (ø)
app/internal/weather_forecast.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab45a02...7a64596. Read the comment docs.

Copy link
Collaborator

@OdeYec OdeYec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!
Please take extra notice of the critical bug I mentioned and that you have added a .exe file that should be added to .gitignore :)

Copy link
Member

@yammesicka yammesicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got few additional insights. Those are probably the last ones.

@yammesicka yammesicka merged commit 0b4570b into PythonFreeCourse:develop Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants