Feature/weather forecast #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lisafiluz
reviewed
Jan 16, 2021
ivarshav
reviewed
Jan 16, 2021
ivarshav
reviewed
Jan 16, 2021
ivarshav
reviewed
Jan 16, 2021
ivarshav
reviewed
Jan 16, 2021
ivarshav
reviewed
Jan 16, 2021
ivarshav
reviewed
Jan 16, 2021
ivarshav
reviewed
Jan 16, 2021
app/weather_forecast.py
Outdated
| """ | ||
| input_date = datetime(year=year, month=month, day=day) | ||
| forecast_type = calculate_forecast_type(input_date) | ||
| if forecast_type == HISTORY_TYPE: |
Contributor
There was a problem hiding this comment.
Maybe you can use a dict instead of many ifs?
Gonzom
reviewed
Jan 16, 2021
yammesicka
requested changes
Jan 17, 2021
yammesicka
requested changes
Jan 19, 2021
Member
|
Awesome progress, I've reviewed the code again and there are some small fixes left. GJ! |
…into feature/weather_forecast
Codecov Report
@@ Coverage Diff @@
## develop #62 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 15 16 +1
Lines 425 544 +119
==========================================
+ Hits 425 544 +119
Continue to review full report at Codecov.
|
yammesicka
requested changes
Jan 23, 2021
…into feature/weather_forecast
…dar2020/calendar into feature/weather_forecast
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature gets weather data for given date & location.
It returns the following: