-
Notifications
You must be signed in to change notification settings - Fork 52
Feature/translations workflow #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Gonzom
wants to merge
136
commits into
PythonFreeCourse:main
from
Gonzom:feature/translations-workflow
Closed
Feature/translations workflow #229
Gonzom
wants to merge
136
commits into
PythonFreeCourse:main
from
Gonzom:feature/translations-workflow
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto feature/shareable-event
…nto style-daily_view
Added dayview template with css and router. An tempreroy event class with, processing function for the day view to work.
Added dayview template with css and router. An tempreroy event class with, processing function for the day view to work. fixed after taking notes.
* Moved the route to top of file
* Added files for sending invitations by email This includes - templates - routes and internal code - configuration - tests Co-authored-by: leddest <46251307+leddest@users.noreply.github.com> Co-authored-by: Ellen <ellenc345@gmail.com>
…c. (PythonFreeCourse#167) * translation feature stuff
* Add basic update event
…into feature/translations-workflow
* Support categories for events
…into feature/translations-workflow
* Hello Wrold * Creating Html Template * Calendar dates calculation intigrating with html, HTML\CSS improvments. * Tests for calender_grid.py, changing function according to currections, fixing bugs * linting bug fixing * before merge with develop * Creating a Day object and days subclasses, changing all function and tests according to the new objects, Changing front to get information from Day objects, Re-arranging calendar.html grid stracture to be render by weeks, adding js functionality for day view section, adding css effects on daily event display * fix lintings * fix lintings * tests next week scroll * js updates * Calendar Scrolling with javascript * Fix lintings * Fix lintings * Calendar infinit scrolling ducplicates weeks bug fixed * seetings global parameters for calendar.py * Js - changing to fetch, removing jquery, fixing hint tpying, adding Week object, changing tests * Front end bug fixing * Fix linting * Fix lintings * Fix lintings * fixing syntax * Get user local date and time when enter calendar. * Fix lintings * Fix lintings * Fix lintings * Bugs fixing * Bugs fixing * Bugs fixing * Bugs fixing * JS alerts removal * Fix Lintings * Js syntext fixing * Bugs fixing * Bugs fixing * Js fixing varibales and adding div element to request. * Develop Update * Js - eliminate global parameters * Linting fixing * Fix Lintings * Fix flake8 * syntac fixing
* feat: add translations workflow * fix(translations-workflow): fix doc * fix(translations-workflow): fixed code and added automatic commit Co-authored-by: Gonny <1@1>
…FreeCourse#208) This reverts commit 2e6a2c2.
…oader (PythonFreeCourse#155) * feat: Add zodiac signs to the day/month view +
…Course#194) when clicking on the logo
* Js scrolling duplication days fixed
Fix the "Task pending" RuntimeError
* feat: astronomy
* feat: add on this day from wiki
* feat: daily horoscope by sign
* Currency feature
* Support adding category to a new or exisiting event
… Fix (PythonFreeCourse#218) * fix: grid responsiveness (fills grid to the bottom now)
…into feature/translations-workflow
* Add telegram client
…into feature/translations-workflow
* feat: add i18n support This feature includes the core functions added to /internal, English and Hebrew json files, removal of text strings from the html files, updates to the routes and model updates. Also included are tests. Please note, that this feature is waiting on user registration for final hooks. * fix(i18n): correct flake8 line length errors * fix(i18n): attempt to fix build crash at get_translations_dicts() and move foreignkey to last column as requested in CR. Additional minor doc fixes. * fix(i18n): simplify check of language file path between live and testing This change hopefully adds this line to the code coverage. * fix(i18n): replace glob with path.glob This change reduces the amount of imports needed and also uses one dir path for both tests and live. * fix(i18n): revert attempted code improvement * fix(i18n): added missing language_id to placeholder user * fix(i18n): added simple test for home * fix(i18n): code review fixes * fix(i18n): split the html result dict into two sub-dicts, "variables" and "localized" and the creation of the Jinja2TemplateResponse is now handled in internal/utilities. * fix(i18n): fixed CR request to not use global state for translations The translations are now handled with @lru_cache and the function is only re-handled when a new language code parameter is used. This should be the last edit (unless any crash) to this version of the translation feature.
…into feature/translations-workflow
Contributor
Author
|
Close, didn't work correcly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resubmit of #150 (comment)
Issue: #149