Skip to content
This repository was archived by the owner on Apr 23, 2025. It is now read-only.

Add reductions and tests #37

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Add reductions and tests #37

merged 2 commits into from
Sep 27, 2024

Conversation

ggeorgakoudis
Copy link
Contributor

No description provided.

DrTodd13
DrTodd13 reviewed Sep 27, 2024
View reviewed changes
Copy link
Contributor

@DrTodd13 DrTodd13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you want to add some tests at this time where the initial value isn't the identity value?

@ggeorgakoudis
Copy link
Contributor Author

Did you want to add some tests at this time where the initial value isn't the identity value?

Yes, that's a good idea. I'll update.

@ggeorgakoudis
Copy link
Contributor Author

Ping @DrTodd13. Tests pass.

@DrTodd13 DrTodd13 merged commit 1fa0b32 into develop Sep 27, 2024
5 checks passed
@ggeorgakoudis ggeorgakoudis deleted the add-reductions-and-tests branch September 27, 2024 19:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DrTodd13 DrTodd13 DrTodd13 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ggeorgakoudis @DrTodd13