This repository was archived by the owner on Apr 23, 2025. It is now read-only.
More loop variants. #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check github testing, it's failing in python in running on CPU (which should not fail): |
ggeorgakoudis
suggested changes
Sep 27, 2024
DrTodd13
force-pushed
the
more_loop_variants
branch
from
1136516 to
bc35088
Compare
|
@DrTodd13 Checks pass! There's some conflicts to resolve. LGTM. |
ggeorgakoudis
approved these changes
Oct 1, 2024
…loop and collapse processing to the enclosing openmp region. 2) Fix bug that checks for distribute being tightly nested within teams. 3) Add bare loop directive. 4) Don't add QUAL.OMP.THREAD_LIMIT on non-team parallel directives. 5) Add test for separate target, teams, and loop.
…able for tags_for_enclosing when there is no collapse clause.
2) Add functions to process schedule_clause and dist_schedule_clause from the grammar. 3) Change loop directive to look at enclosing region and generate distribute parallel for if in a teams region and parallel for otherwise. 4) Add kind of failure to all CPU-target-backend skipped cases. 5) Add test for loop directive on CPU side.
… that if inside distribute then just parallel loop is used.
DrTodd13
force-pushed
the
more_loop_variants
branch
from
bc35088 to
51b7919
Compare
DrTodd13
added a commit
that referenced
this pull request
Oct 9, 2024
* Add loop directive variants * Add tests * Adding way to skip test only for device=1 * Remove old comments * Process schedule_clause and dist_schedule_clause from the grammar
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add teams loop and bare loop directives. Add tests for those but the teams loop one is skipped for now due to need for backend support. Fix some bugs related to having separate directives instead of combined.