This repository was archived by the owner on Apr 23, 2025. It is now read-only.
Fix reduction for FP type #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrTodd13
approved these changes
Sep 27, 2024
ggeorgakoudis
force-pushed
the
fix-reductions
branch
from
d9b1b65 to
b876c38
Compare
- Using atomicrmw for FP is problematic on aarch64, switch to codegen using cmpxchg - Template reduction impl. for extensibility - Update cmake building (set C++ standard, dynamically link with llvmdev) - Unify error handling
ggeorgakoudis
force-pushed
the
fix-reductions
branch
from
b876c38 to
690ca53
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cmpxchg