Skip to content
This repository was archived by the owner on Dec 22, 2023. It is now read-only.

Stock Scraper feature #119

Merged
merged 17 commits into from
Oct 3, 2020
Merged

Stock Scraper feature #119

merged 17 commits into from
Oct 3, 2020

Conversation

antoniouaa
Copy link
Contributor

@antoniouaa antoniouaa commented Oct 1, 2020

Description

The script fetches the company names and symbols for the S&P500 companies off of Wikipedia and then uses the yfinance library to grab financial information for them for the last 3 months.

The script saves a file to the disk with the symbols and names of the S&P500 companies and then asks the user whether to save the data for each company to the disk or not.

Fixes #51

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation Update

Checklist:

  • I have named my files and folder, according to this project's guidelines.
  • My code follows the style guidelines of this project.
  • My Pull Request has a descriptive title. (not a vague title like Update index.md)
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have created a helpful and easy to understand README.md, according to the given README_TEMPLATE.
  • I have included a requirements.txt file (if external libraries are required.)
  • My changes do not produce any warnings.
  • I have added a working sample/screenshot of the script.

Copy link
Member

@AdityaJ7 AdityaJ7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job @antoniouaa just add some comments and change the name of your folder to something better like Stock scraper or whatever you like. everything else works fine

@tusharnankani
Copy link
Member

tusharnankani commented Oct 2, 2020

Please add a working screenshot, of the script.
Also, add lxml to requirements.txt

@antoniouaa
Copy link
Contributor Author

I'm not sure what you mean by working screenshot of the script

@AdityaJ7
Copy link
Member

AdityaJ7 commented Oct 2, 2020

I'm not sure what you mean by working screenshot of the script

You can refer the existing scripts in this repo for better clarity

@antoniouaa
Copy link
Contributor Author

Just an FYI, that linter error is not from my branch

@antoniouaa antoniouaa requested a review from AdityaJ7 October 2, 2020 22:45
@AdityaJ7
Copy link
Member

AdityaJ7 commented Oct 3, 2020

@all-contributors please add @antoniouaa for code

@AdityaJ7 AdityaJ7 merged commit 7c6fba7 into Python-World:master Oct 3, 2020
@allcontributors
Copy link
Contributor

@AdityaJ7

I've put up a pull request to add @antoniouaa! 🎉

Copy link
Member

@tusharnankani tusharnankani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @antoniouaa! 👍🏻

Expecting more contributions from your end!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stock scraper
3 participants