Gh actions tests #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As 3.4 and 3.5 are no longer supported by Python, I see no need to support them either. Let's drop them and then we don't need to do anything special to accommodate them. Also, the conflict needs to be resolved now that I've merged #8. |
- Different python version specs are moved from `tox.ini` to CI config. - Ubuntu 18.04 is used since `latest` doesn't support python 3.4. - Flake8 complained about some test syntax, so that's fixed.
as requested, since they're no longer supported.
uniphil
force-pushed
the
gh-actions-tests
branch
from
3c833d8 to
8f23493
Compare
|
awesome. done & done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #8 -- switches CI to use Github Actions.
I tried to change as little as possible while still making it work:
tox.inito CI config.latestdoesn't support python 3.4.\\@)Example run