Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix node registration ip on dual stack #230

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

logan2211
Copy link

When using a user defined node ip on a dual stack cluster, k3s_node_ip will contain "ipv4,ipv6" IP. In order to properly set the registration IP, the first (preferred) IP in the list is used, and if it is the IPv6 IP it will be URL wrapped.

When using a user defined node ip on a dual stack cluster,
k3s_node_ip will contain "ipv4,ipv6" IP. In order to properly set
the registration IP, the first (preferred) IP in the list is used,
and if it is the IPv6 IP it will be URL wrapped.
@logan2211
Copy link
Author

FYI, tested 4 different ways:

  • single stack, ipv4: k3s_node_ip set to "10.0.0.0"
  • single stack, ipv6: k3s_node_ip set to "fdfc:0f9d:6133::2"
  • dual stack, ipv4 preferred: k3s_node_ip = "10.0.0.0,fdfc:0f9d:6133::2"
  • dual stack, ipv6 preferred: k3s_node_ip = "fdfc:0f9d:6133::2,10.0.0.0"

All work as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant