Skip to content

Conversation

@charles-dyfis-net
Copy link

Avoids downloading full member list during group lookup (an unwieldy use of bandwidth and cache space).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably better as:

 attrlist = kw.get('attrlist')
 if attrlist is not None:
     attrlist = tuple(sorted(attrlist))

 cache_key = ( ....
   attrlist
  )

If only because there needn't be a requirement that attrlist be an actual list instance (e.g. if it's already a tuple).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the above is probably superseded by the comment below.

@mcdonc
Copy link
Member

mcdonc commented Apr 24, 2013

See comments above.

If you choose to make changes like this, maybe you could also add your name to the file I just added to the master named CONTRIBUTORS.txt within an update to this pull request and also add a change note the the CHANGES.txt file and update the docs in docs/index.rst with whatever changes you have?

@charles-dyfis-net
Copy link
Author

Sorry about the delay there -- took a little longer than I intended to get signoff. Should be ready for merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants