Skip to content

Conversation

luhn
Copy link
Contributor

@luhn luhn commented Aug 25, 2025

Builds are waiting for 24hrs then timing out because the images we're using are no longer supported. This PR:

  • Bumps images to -latest variants
  • Removes architecture from matrix, defaulting to architecture of the runner.
  • Removes --cov from tests.

@luhn
Copy link
Contributor Author

luhn commented Aug 25, 2025

There's definitely some discussion to be had here.

Bumps images to -latest variants

Could have also done ubuntu-24.04 etc but I think it's a good thing if our runners keep on the latest images.

Removes architecture from matrix, defaulting to architecture of the runner.

Because macos runners are now arm64, we would have needed to add that to the architecture list and expand our exclusions, at that point excluded runners would outnumber the rest. Seems better to just go with whatever architecture the runner OS is.

The only real thing we're losing here is x86 tests. They were only supported on Windows anyways, and I'm not sure if x86 is even relevant anymore.

Removes --cov from tests.

Not sure why this was there, I can't think what it adds that the dedicated coverage test doesn't already handle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant