-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding test case for deform #103 issue #16
Conversation
@tonthon I would like to merge this PR, if you rebase it on A new issue for |
@stevepiercy here it is. Sorry for the delay, not working so much lately |
@tonthon for the lint failure, you can use Also for running tests, you can run a single functional test locally until it passes. See https://github.com/Pylons/deform/blob/master/contributing.md in the Deform repo for full details. Finally v3.0 of Deform drops end-of-life Pythons. |
Test still fail with the current deform master branch (I don't know what was expected) |
@@ -2736,6 +2736,16 @@ def test_submit_filled(self): | |||
# py2/py3 compat, py2 adds extra u prefix | |||
self.assertTrue("bar" in text) | |||
|
|||
def test_special_chars(self): | |||
findid('deformField1').send_keys('foo') | |||
self.assertTrue(findxpath('//p[text()="foo & bar"]').is_displayed()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I type foo & bar
in the input field, no text is displayed in the popup, so this test should fail, but it appears to pass.
self.assertRaises(NoSuchElementException, findcss, ".has-error") | ||
text = findid("captured").text | ||
# py2/py3 compat, py2 adds extra u prefix | ||
self.assertTrue("foo & bar" in text) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will fail because the output is:
{'text': 'foo '
'& '
'bar'}
I figured it out. This had a chain (literally) of nasty issues, which I only discovered by comparing DetailsFirst we need to add the option We need to add the The test was not actually clicking the element from
I created a new function to use Finally |
Closed in favor of #75 |
Re-opened pull request.
Do not merge this one until some improvement is done on the provided solution see original issue :
Pylons/deform#103