Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable other value types than strings in CheckboxChoiceTemplate #173

Closed
wants to merge 1 commit into from
Closed

Enable other value types than strings in CheckboxChoiceTemplate #173

wants to merge 1 commit into from

Conversation

renumi
Copy link

@renumi renumi commented Jul 24, 2013

if cstruct is a list of integers no checkbox was checked.

if cstruct is a list of integers no checkbox was checked.
@mcdonc
Copy link
Member

mcdonc commented Oct 4, 2013

Thanks for the patch!

On this issue, I'd like to have a more general rule about things. Several other widgets may need the same sort of treatment (radio choice widget, select-multiple widgets, etc). I don't really know what the right thing is yet. There is some stab at this already in the call to _normalize_choices in various widgets, but I don't think we have it quite right yet.

So I'm going to leave this pull request open as a reminder, although it is unlikely to be applied as-is.

@stevepiercy
Copy link
Member

This PR needs to follow the pattern set in #81 and #88, and in deformdemo in Pylons/deformdemo#7 and Pylons/deformdemo#8.

@stevepiercy
Copy link
Member

Hi @renumi, I've taken on the role of maintainer for Deform. Would you please follow the request in my comment, sign https://github.com/Pylons/deform/blob/master/CONTRIBUTORS.txt, resolve merge conflicts, and push to your PR? Then I will merge.

Please let me know. Thank you!

Base automatically changed from master to main January 19, 2021 10:23
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants