Format project to adhere to PEP8 standards and best practices #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krittick
added
priority: high
krittick
requested review from
Lulalaby,
Dorukyum,
ChickenDevs,
BobDotCom and
Middledot
# Conflicts: # discord/__init__.py # discord/bot.py # discord/opus.py # discord/threads.py # discord/voice_client.py
i.e. most (but not all) of these: https://github.com/sourcery-ai/sourcery/wiki/Current-Refactorings
# Conflicts: # discord/__main__.py # discord/abc.py # discord/activity.py # discord/asset.py # discord/bot.py # discord/client.py # discord/cog.py # discord/commands/core.py # discord/components.py # discord/ext/commands/converter.py # discord/ext/commands/flags.py # discord/flags.py # discord/guild.py # discord/integrations.py # discord/interactions.py # discord/iterators.py # discord/message.py # discord/player.py # discord/role.py # discord/scheduled_events.py # discord/state.py # discord/ui/button.py # discord/utils.py # discord/webhook/async_.py # discord/webhook/sync.py # discord/welcome_screen.py
|
This shouldn't contain any breaking changes, and has now been fairly well tested. All changes are simply to update the code to PEP8 standards, refactor and simplify conditionals, etc. I recommend that we merge this as soon as possible so that PRs can target a higher quality codebase and meet these standards. |
ImNimboss
previously approved these changes
Feb 9, 2022
|
Relevant: |
# Conflicts: # discord/audit_logs.py # discord/bot.py # discord/cog.py # discord/commands/core.py # discord/components.py # discord/enums.py # discord/ext/commands/cog.py # discord/ext/commands/converter.py # discord/ext/commands/flags.py # discord/interactions.py # discord/state.py # discord/types/interactions.py # discord/types/message.py # discord/ui/__init__.py # discord/welcome_screen.py # examples/app_commands/slash_options.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update of #768 and #794 to include newer changes from
masterthat couldn't easily be merged otherwise.Checklist
type: ignorecomments were used, a comment is also left explaining why