Skip to content

Fix behaviour of ScheduledEvent subs iterator #810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 21, 2022
Merged

Fix behaviour of ScheduledEvent subs iterator #810

merged 5 commits into from
Jan 21, 2022

Conversation

Middledot
Copy link
Member

Summary

Followup to #781
Fixes #771, #772, #773, #780

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@Middledot Middledot added the bug Something isn't working label Jan 18, 2022
@Middledot Middledot enabled auto-merge (squash) January 18, 2022 01:20
This was linked to issues Jan 18, 2022
"site-packages\discord\user.py", line 110, in _update: self.name = data['username'] KeyError: 'username'" on event.subscribers #772
Closed
Can't use event.subscribers without before & after #773
Closed
ScheduledEvent.subscribers() and event.subsciber_count don't work #780
Closed
@Lulalaby Lulalaby added this to the v2.0 milestone Jan 18, 2022
Dorukyum
Dorukyum reviewed Jan 21, 2022
View reviewed changes
@Lulalaby Lulalaby disabled auto-merge January 21, 2022 12:39
@Middledot Middledot enabled auto-merge January 21, 2022 18:04
@Lulalaby Lulalaby disabled auto-merge January 21, 2022 18:06
@Lulalaby Lulalaby enabled auto-merge (squash) January 21, 2022 18:06
@Lulalaby Lulalaby merged commit 2e48b7d into Pycord-Development:master Jan 21, 2022
VincentRPS pushed a commit to VincentRPS/pycord that referenced this pull request Jan 22, 2022
@Middledot @VincentRPS
Fix behaviour of ScheduledEvent subs iterator (Pycord-Development#810)
8ace2a5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes

@Dorukyum Dorukyum Dorukyum approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v2.0
3 participants
@Middledot @Lulalaby @Dorukyum