Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove useless lambda functions #689

Merged
merged 2 commits into from
Jan 21, 2022
Merged

remove useless lambda functions #689

merged 2 commits into from
Jan 21, 2022

Conversation

Sengolda
Copy link
Contributor

@Sengolda Sengolda commented Jan 3, 2022

Summary

Removed useless lambda functions in run() method.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@ChickenDevs
Copy link
Member

You have already implemented this in #682. Was this intentional?

@Sengolda
Copy link
Contributor Author

Sengolda commented Jan 4, 2022

You have already implemented this in #682. Was this intentional?

No, Sorry I forgot I added it in #682

@Lulalaby Lulalaby added this to the v2.1 milestone Jan 7, 2022
@Lulalaby Lulalaby added priority: medium Medium Priority feature Implements a feature Merge with squash labels Jan 7, 2022
@krittick krittick mentioned this pull request Jan 18, 2022
Closed
Dorukyum
Dorukyum previously approved these changes Jan 21, 2022
View reviewed changes
Lulalaby
Lulalaby previously approved these changes Jan 21, 2022
View reviewed changes
@Lulalaby Lulalaby dismissed stale reviews from Dorukyum and themself via f0acba8 January 21, 2022 12:40
@Lulalaby Lulalaby enabled auto-merge (squash) January 21, 2022 12:40
@Lulalaby Lulalaby requested a review from Dorukyum January 21, 2022 12:41
@Lulalaby Lulalaby merged commit c3265c2 into Pycord-Development:master Jan 21, 2022
VincentRPS pushed a commit to VincentRPS/pycord that referenced this pull request Jan 22, 2022
@Sengolda @Lulalaby @VincentRPS
remove useless lambda functions (Pycord-Development#689)
ab0ab56 
Co-authored-by: Lala Sabathil <lala@pycord.dev>
@VincentRPS VincentRPS modified the milestones: v2.1, v2.0 Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dorukyum Dorukyum Dorukyum approved these changes

@Lulalaby Lulalaby Lulalaby approved these changes

Assignees
No one assigned
Labels
feature Implements a feature priority: medium Medium Priority
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Sengolda @ChickenDevs @Lulalaby @Dorukyum @VincentRPS