-
-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OptionChoice
Bug Fix
#679
Merged
Merged
OptionChoice
Bug Fix
#679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krittick
approved these changes
Jan 2, 2022
What does this change? Slash command groups don't get inputs |
VincentRPS
requested changes
Jan 2, 2022
Groups & Subcommands are internally considered options by Discord. When the library tries to send them it raises an exception similar to the one in the referenced PR, but with |
s0hv
reviewed
Jan 2, 2022
Middledot
approved these changes
Jan 7, 2022
Dorukyum
approved these changes
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
AddsFixed in f9e58a5input_type
toSlashCommandGroup
(Kind of adds on to #676)Fixed a bug in
OptionChoice
where you couldn't provide a false value (such as0
) tovalue
Checklist
type: ignore
comments were used, a comment is also left explaining why