Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OptionChoice Bug Fix #679

Merged
merged 2 commits into from
Jan 7, 2022
Merged

OptionChoice Bug Fix #679

merged 2 commits into from
Jan 7, 2022

Conversation

plun1331
Copy link
Member

@plun1331 plun1331 commented Jan 2, 2022

Summary

Adds input_type to SlashCommandGroup (Kind of adds on to #676) Fixed in f9e58a5

Fixed a bug in OptionChoice where you couldn't provide a false value (such as 0) to value

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@Dorukyum
Copy link
Member

Dorukyum commented Jan 2, 2022

What does this change? Slash command groups don't get inputs

@plun1331
Copy link
Member Author

plun1331 commented Jan 2, 2022

What does this change? Slash command groups don't get inputs

Groups & Subcommands are internally considered options by Discord.

When the library tries to send them it raises an exception similar to the one in the referenced PR, but with input_type.

@Lulalaby
Copy link
Member

Lulalaby commented Jan 2, 2022

Groups & Subcommands are internally considered options by Discord.

When the library tries to send them it raises an exception similar to the one in the referenced PR, but with input_type.

that-this

discord/commands/commands.py Outdated Show resolved Hide resolved
@plun1331 plun1331 changed the title Slash Command Bug Fixes OptionChoice Bug Fix Jan 5, 2022
@Lulalaby Lulalaby added this to the v2.0 milestone Jan 7, 2022
@Lulalaby Lulalaby added bug Something isn't working priority: medium Medium Priority Merge with squash labels Jan 7, 2022
@Dorukyum Dorukyum merged commit 7c0eeeb into Pycord-Development:master Jan 7, 2022
@plun1331 plun1331 deleted the patch-7 branch January 10, 2022 21:07
VincentRPS pushed a commit to VincentRPS/pycord that referenced this pull request Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: medium Medium Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants