Treating None embeds and views as not having embeds and views in send_message #671
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When you call
ctx.respond
(sending messages, not editing them) and other similar methods, you currently have to put them in an if block to decide whether to include embeds and/or views. With this PR, they'll be able to correctly handle a None, allowing usage of a variable or ternary expression. For instance,can now be simplified to:
Checklist
type: ignore
comments were used, a comment is also left explaining why (N/A)