Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ext.menus pagination module #539

Merged
merged 57 commits into from
Dec 19, 2021
Merged

Add ext.menus pagination module #539

merged 57 commits into from
Dec 19, 2021

Conversation

krittick
Copy link
Contributor

@krittick krittick commented Dec 4, 2021

Summary

Adds a pagination module, building on the initial work done by @LilJess13 and others in #68

Works with prefixed and slash commands, and can be sent as a response to an interaction.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@Lulalaby Lulalaby added feature Implements a feature documentation Improvements or additions to documentation priority: medium Medium Priority status: in progress Work in Progess labels Dec 4, 2021
@Lulalaby Lulalaby added this to the v2.0 milestone Dec 4, 2021
@krittick
Copy link
Contributor Author

Added two more key bits of functionality:

  • self.message now stores the message that gets sent with the paginator
  • on_timeout event added which disables all buttons associated with the paginator view (including custom view buttons) if disable_on_timeout is set to True (which is the default).
    • This results in a better user experience for views that time out instead of users receiving the "This interaction failed" error.

VincentRPS
VincentRPS previously approved these changes Dec 15, 2021
Copy link
Member

@VincentRPS VincentRPS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me to be merged will have to test tho

@Lulalaby Lulalaby enabled auto-merge (squash) December 15, 2021 04:59
auto-merge was automatically disabled December 19, 2021 01:31

Head branch was pushed to by a user without write access

@Lulalaby Lulalaby enabled auto-merge (squash) December 19, 2021 21:22
@Lulalaby Lulalaby merged commit 3d04a71 into Pycord-Development:master Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation feature Implements a feature priority: medium Medium Priority status: in progress Work in Progess
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants