Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fix for typing for ApplicationContext.author #464

Merged
merged 3 commits into from
Nov 16, 2021
Merged

Add fix for typing for ApplicationContext.author #464

merged 3 commits into from
Nov 16, 2021

Conversation

krittick
Copy link
Contributor

@krittick krittick commented Nov 16, 2021

Summary

This changes the current simple variable assignment of author = user to a cached property of ApplicationContext instead, while retaining the existing functionality. This allows type hinting to function properly when resolving members of .author

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@Lulalaby Lulalaby enabled auto-merge November 16, 2021 05:59
@Lulalaby Lulalaby requested review from BobDotCom, CodeWithSwastik and izxxr and removed request for BobDotCom and CodeWithSwastik November 16, 2021 05:59
@Lulalaby Lulalaby added bug Something isn't working priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer labels Nov 16, 2021
@Lulalaby Lulalaby merged commit b1af06c into Pycord-Development:master Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants