Adding file and files keyword arguments to discord.Message.edit #417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added edit_files and edit_multipart_helper functions
Added file and files keyword arguments into the edit function Edited docstrings for the file and files keyword arguments
Added an extra edit function with overload decorator, with file and files keyword arguments
Default value for file and files keyword argument changed from None to MISSING
state.http.edit_files -> self._state.http.edit_files
channel.id -> self.channel.id
Reedited and simplified message.py
Reedited and simplified http.py
EnokiUN
suggested changes
Nov 8, 2021
Contributor
EnokiUN
left a comment
EnokiUN
left a comment
There was a problem hiding this comment.
Looks great, just add comments to make it clear what you're doing.
Contributor
Author
Basically the same as send_files but changing route method to 'PATCH' and also handles some missing arguments. |
Contributor
|
It's pretty straightforward comments aren't really necessary imo |
Member
|
These are not to be used manually, so as Zeffo said comments are not necessary. |
izxxr
added
feature
Lulalaby
previously approved these changes
Nov 8, 2021
BobDotCom
requested changes
Nov 8, 2021
Contributor
BobDotCom
left a comment
BobDotCom
left a comment
There was a problem hiding this comment.
Please merge the head branch into this so checks can run correctly
BobDotCom
requested changes
Nov 11, 2021
auto-merge was automatically disabled
November 11, 2021 04:44
Head branch was pushed to by a user without write access
Lulalaby
approved these changes
Nov 11, 2021
BobDotCom
approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added file and files keyword arguments to discord.Message.edit
file: Sequence[:class:
File]To add a new file to the message
files: List[Sequence[:class:
File]]To add new files to the message
Checklist
Note
Test it out before merging, there might be other errors.