Skip to content

Add example for slash commands in cogs. #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Lulalaby merged 3 commits into from
Oct 30, 2021
Merged

Add example for slash commands in cogs. #341

Lulalaby merged 3 commits into from
Oct 30, 2021

Conversation

@Sengolda
Copy link
Contributor

@Sengolda Sengolda commented Oct 28, 2021 •
edited
Loading

Summary

This pull request adds an example for slash commands in cogs.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new
  • This PR is a breaking change
  • This PR is not a code change (e.g. documentation, README, typehinting, ...)

@Lulalaby Lulalaby added the documentation Improvements or additions to documentation label Oct 30, 2021
@Lulalaby Lulalaby changed the title Added an example for slash commands in cogs. Add example for slash commands in cogs. Oct 30, 2021
@Lulalaby Lulalaby added the status: awaiting review Awaiting review from a maintainer label Oct 30, 2021
@Lulalaby Lulalaby requested review from a team, FrostByte266, Lulalaby and WhoIsConch and removed request for a team October 30, 2021 04:51
Lulalaby
Lulalaby previously approved these changes Oct 30, 2021
View reviewed changes
@Dorukyum
Copy link
Member

Dorukyum commented Oct 30, 2021

It could be better if you put some comments to explain the code

@Lulalaby
Copy link
Member

Lulalaby commented Oct 30, 2021

It could be better if you put some comments to explain the code

true

@Lulalaby Lulalaby requested review from BobDotCom, Dorukyum and Lulalaby and removed request for FrostByte266 and WhoIsConch October 30, 2021 08:55
@Sengolda
Copy link
Contributor Author

Sengolda commented Oct 30, 2021

It could be better if you put some comments to explain the code

Every part? or just the parts where we are making slash commands?

@Lulalaby
Copy link
Member

Lulalaby commented Oct 30, 2021

It could be better if you put some comments to explain the code

Every part? or just the parts where we are making slash commands?

Document it so newbies can understand what's happening there.

@Lulalaby Lulalaby added status: in progress Work in Progess and removed status: awaiting review Awaiting review from a maintainer labels Oct 30, 2021
@Lulalaby Lulalaby enabled auto-merge October 30, 2021 09:47
@Lulalaby Lulalaby added status: awaiting review Awaiting review from a maintainer and removed status: in progress Work in Progess labels Oct 30, 2021
Lulalaby
Lulalaby requested changes Oct 30, 2021
View reviewed changes
@Lulalaby Lulalaby added the status: in progress Work in Progess label Oct 30, 2021
@Lulalaby Lulalaby merged commit e3bde55 into Pycord-Development:master Oct 30, 2021
@Dorukyum Dorukyum mentioned this pull request Nov 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes

@Dorukyum Dorukyum Dorukyum approved these changes

@BobDotCom BobDotCom Awaiting requested review from BobDotCom

Assignees

@Sengolda Sengolda

Labels

documentation Improvements or additions to documentation status: awaiting review Awaiting review from a maintainer status: in progress Work in Progess

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Sengolda @Dorukyum @Lulalaby