Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support responding with deferred_channel_message to component interactions. #309

Merged
merged 6 commits into from
Nov 11, 2021
Merged

Support responding with deferred_channel_message to component interactions. #309

merged 6 commits into from
Nov 11, 2021

Conversation

plun1331
Copy link
Member

Summary

Allows users to choose between deferred_channel_message and deferred_message_update when responding to a component interaction.

image

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, ...)

@BobDotCom
Copy link
Member

couldn't you just ctx.defer(ephermal=True)?

@plun1331
Copy link
Member Author

couldn't you just ctx.defer(ephermal=True)?

The ephermal kwarg currently doesn't do anything unless it's an application command. This PR changes that behavior.

@Lulalaby Lulalaby added feature Implements a feature priority: low Low Priority status: in progress Work in Progess labels Oct 30, 2021
@Lulalaby Lulalaby requested review from a team, Lulalaby, FrostByte266 and Dorukyum and removed request for a team October 30, 2021 06:50
Lulalaby
Lulalaby requested changes Oct 30, 2021
View reviewed changes
Copy link
Member

@Lulalaby Lulalaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you removed the new lines

Middledot
Middledot reviewed Oct 30, 2021
View reviewed changes
discord/interactions.py Outdated Show resolved Hide resolved
discord/interactions.py Outdated Show resolved Hide resolved
discord/interactions.py Outdated Show resolved Hide resolved
@Lulalaby Lulalaby removed the request for review from FrostByte266 October 30, 2021 22:54
@Lulalaby Lulalaby enabled auto-merge October 31, 2021 06:50
@Lulalaby
Copy link
Member

Lulalaby commented Nov 1, 2021

discord/discord-api-docs#4035 < keep in mind

BobDotCom
BobDotCom reviewed Nov 2, 2021
View reviewed changes
discord/interactions.py Outdated Show resolved Hide resolved
@BobDotCom
Copy link
Member

Actually, could we just implement this into ctx.defer?

@Lulalaby @BobDotCom
Update discord/interactions.py
be63b41 
Co-authored-by: BobDotCom <71356958+BobDotCom@users.noreply.github.com>
@Lulalaby
Copy link
Member

Lulalaby commented Nov 2, 2021

Actually, could we just implement this into ctx.defer?

Would be better

@Lulalaby Lulalaby disabled auto-merge November 2, 2021 15:02
@Lulalaby Lulalaby requested a review from BobDotCom November 2, 2021 15:03
@BobDotCom BobDotCom enabled auto-merge November 11, 2021 05:03
@BobDotCom BobDotCom merged commit 9eb30ae into Pycord-Development:master Nov 11, 2021
@plun1331 plun1331 mentioned this pull request Nov 11, 2021
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BobDotCom BobDotCom BobDotCom approved these changes

@Lulalaby Lulalaby Lulalaby approved these changes

@Dorukyum Dorukyum Awaiting requested review from Dorukyum Dorukyum is a code owner automatically assigned from Pycord-Development/maintainers

@Middledot Middledot Awaiting requested review from Middledot

Assignees

@plun1331 plun1331

Labels
feature Implements a feature priority: low Low Priority status: in progress Work in Progess
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@plun1331 @BobDotCom @Lulalaby @Middledot