feat: allow conversion to Member in MentionableConverter #2775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
|
fix of #2394 |
Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
Lumabots
changed the title
|
ready for review |
|
This isn't really a bug fix, more of a feature |
plun1331
changed the title
I'll edit the change then |
Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
plun1331
reviewed
May 9, 2025
Comment on lines
+640
to
+642
| if input_type == discord.Member: | ||
| self.converter = MemberConverter() | ||
| else: |
There was a problem hiding this comment.
why'd this get put here? this should be handled by converter mappings
There was a problem hiding this comment.
I followed this, if you prefer to make me do it differently, can you explain me how you would like it ?
#2394 (comment)
There was a problem hiding this comment.
well it's no different than just removing it since it's in BRIDGE_CONVERTER_MAPPING ALREADY
There was a problem hiding this comment.
if someone can understand why without this init it doesnt work, feel free to help
Co-authored-by: plun1331 <plun1331@gmail.com> Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.