Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🏷️ Fix types in Select.__init__ #2746

Merged
merged 3 commits into from
Mar 21, 2025

Conversation

Paillat-dev
Copy link
Contributor

@Paillat-dev Paillat-dev commented Mar 21, 2025

Summary

Without this change, instantiating any select menu could (depending on your type checker settings) trigger an error, because the default value of the parameters doesn't match the parameter's type.

image

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@Paillat-dev Paillat-dev marked this pull request as ready for review March 21, 2025 12:55
@Paillat-dev Paillat-dev requested a review from a team as a code owner March 21, 2025 12:55
@pullapprove4 pullapprove4 bot requested a review from VincentRPS March 21, 2025 12:55
Co-authored-by: plun1331 <plun1331@gmail.com>
Signed-off-by: Paillat <jeremiecotti@ik.me>
@Lulalaby Lulalaby merged commit 46adb25 into Pycord-Development:master Mar 21, 2025
27 of 28 checks passed
@Paillat-dev Paillat-dev deleted the fix/select-menu-types branch March 21, 2025 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants