Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle improper 1000 closures by discord #2632

Merged
merged 2 commits into from
Oct 29, 2024
Merged

fix: handle improper 1000 closures by discord #2632

merged 2 commits into from
Oct 29, 2024

Conversation

Quintenvw
Copy link
Contributor

Summary

Due to an oversight, the library doesn't handle improper 1000 closures by Discord well.
This causes bots to burn sessions and potentially get a token reset.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@Quintenvw
Handle improper 1000 closures by Discord
42e4849 
Signed-off-by: Quintenvw <contact@quintenvw.com>
@Quintenvw Quintenvw requested a review from a team as a code owner October 29, 2024 09:43
@pullapprove4 pullapprove4 bot requested a review from VincentRPS October 29, 2024 09:43
@Lulalaby Lulalaby changed the title Handle improper 1000 closures by Discord fix: handle improper 1000 closures by discord Oct 29, 2024
@Lulalaby Lulalaby requested review from Lulalaby and removed request for VincentRPS October 29, 2024 09:45
@Lulalaby Lulalaby merged commit e25ea6f into Pycord-Development:master Oct 29, 2024
25 checks passed
OmLanke pushed a commit to OmLanke/pycord that referenced this pull request Dec 16, 2024
@Quintenvw @pre-commit-ci @OmLanke
fix: handle improper 1000 closures by discord (Pycord-Development#2632)
cd5473a 
* Handle improper 1000 closures by Discord

Signed-off-by: Quintenvw <contact@quintenvw.com>

* style(pre-commit): auto fixes from pre-commit.com hooks

---------

Signed-off-by: Quintenvw <contact@quintenvw.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Quintenvw @Lulalaby