-
-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make FFmpegOpusAudio codec behave as docs suggest #2581
fix: make FFmpegOpusAudio codec behave as docs suggest #2581
Conversation
should we maybe change the docs instead because like, breaking changes and stuff |
It's more an internal change. So I wouldn't consider it breaking |
This is my first contribution here so I don't really know if this would count as breaking or not. I checked the box only because it technically changes the behavior of this function. |
I don't think this is going to be much an issue since the only scenario it would break functionality on existing bots would be someone passing in "copy" for a source that isn't opus, which is something that was never supposed to work according to the docs. |
I see this tagged with "changelog needed", is there anything that I need to do? If so are there instructions? |
Here's an example of a changelog entry being added: 7fb1a4b |
would this be "Fixed" or "Changed" ? |
Fixed |
I have added an entry to the changelog. |
Co-authored-by: JustaSqu1d <89910983+JustaSqu1d@users.noreply.github.com> Signed-off-by: felix920506 <felix920506@gmail.com>
…pment#2581) * make ffmpegopusaudio codec behave according to docs * style(pre-commit): auto fixes from pre-commit.com hooks * Update CHANGELOG.md * Apply suggestions from code review Co-authored-by: JustaSqu1d <89910983+JustaSqu1d@users.noreply.github.com> Signed-off-by: felix920506 <felix920506@gmail.com> * style(pre-commit): auto fixes from pre-commit.com hooks --------- Signed-off-by: felix920506 <felix920506@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: JustaSqu1d <89910983+JustaSqu1d@users.noreply.github.com>
…pment#2581) * make ffmpegopusaudio codec behave according to docs * style(pre-commit): auto fixes from pre-commit.com hooks * Update CHANGELOG.md * Apply suggestions from code review Co-authored-by: JustaSqu1d <89910983+JustaSqu1d@users.noreply.github.com> Signed-off-by: felix920506 <felix920506@gmail.com> * style(pre-commit): auto fixes from pre-commit.com hooks --------- Signed-off-by: felix920506 <felix920506@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: JustaSqu1d <89910983+JustaSqu1d@users.noreply.github.com>
Summary
make FFmpegOpusAudio "codec" parameter behave as what the inline docs suggest
Original behavior:
passing in "libopus" or "opus" will result in "copy" being passed into ffmpeg
passing in anything else (including "copy") will result in "libopus" being passed into ffmpeg
New behavior:
passing in "copy" will result in "copy" being passed into ffmpeg
passing in anything else (including "libopus", "opus") will result in "libopus" being passed into ffmpeg
Information
examples, ...).
Checklist
type: ignore
comments were used, a comment is also left explaining why.