Skip to content

fix: options initializing with null input type #2464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 23, 2024
Merged

fix: options initializing with null input type #2464

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9f9dfb1
Prevent Option.__init__() completing with a null input type
nexy7574 May 27, 2024
051818a
Update changelog (for the checkbox)
nexy7574 May 28, 2024
abf2eeb
style(pre-commit): auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 28, 2024
c3449d1
Update CHANGELOG.md
Dorukyum May 30, 2024
b5725b7
style(pre-commit): auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 30, 2024
775c999
Merge branch 'master' into master
Dorukyum Jun 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,9 @@ These changes are available on the `master` branch, but have not yet been releas
([#2448](https://github.com/Pycord-Development/pycord/pull/2448))
- Fixed missing `application_id` in `Entitlement.delete`.
([#2458](https://github.com/Pycord-Development/pycord/pull/2458))
- Fixed `AttributeError` in `register_commands` when a `discord.Option` was constructed
with its `input_type` set to `None`
([#2464](https://github.com/Pycord-Development/pycord/pull/2464))

### Changed

Expand Down
3 changes: 3 additions & 0 deletions discord/commands/options.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,6 +330,9 @@ def __init__(
"description_localizations", MISSING
)

if input_type is None:
raise TypeError("input_type cannot be NoneType.")

def to_dict(self) -> dict:
as_dict = {
"name": self.name,
Expand Down