Skip to content

Conversation

@NeloBlivion
Copy link
Member

Summary

Fixes #2381
Paginator.edit sets self.user to the message author... but since you can only edit your own messages, user is set to the bot and so breaks author_check. This changes it so you can specify any user for paginator.edit, otherwise uses the existing user if it was already set.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@Lulalaby Lulalaby enabled auto-merge (squash) March 9, 2024 21:25
@Dorukyum
Copy link
Member

As this adds a new parameter, we could have a changelog entry under the "Added" section too.

@Revnoplex
Copy link
Contributor

This should fix #1877 too? As the now dead pr #2105 talked about fixing the exact same missing feature/bug related to both #1877 and #2381

@Lulalaby
Copy link
Member

Please stop asking around, if it fixes that, we'll link it on merge

@Dorukyum Dorukyum self-requested a review March 12, 2024 09:07
auto-merge was automatically disabled March 15, 2024 21:05

Head branch was pushed to by a user without write access

Lulalaby
Lulalaby previously approved these changes Mar 17, 2024
Signed-off-by: plun1331 <plun1331@gmail.com>
@plun1331 plun1331 enabled auto-merge (squash) March 19, 2024 17:16
@plun1331 plun1331 assigned plun1331 and unassigned plun1331 Mar 19, 2024
@plun1331 plun1331 added the bug Something isn't working label Mar 19, 2024
@plun1331 plun1331 added the feature Implements a feature label Mar 19, 2024
@plun1331 plun1331 added this to the v2.6 milestone Mar 19, 2024
@plun1331 plun1331 requested a review from Lulalaby March 19, 2024 17:17
@plun1331 plun1331 merged commit 43a9ee7 into Pycord-Development:master Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working feature Implements a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Paginator author check

5 participants