Skip to content

fix: Proper type-hinting & docstring of Member.move_to and Member.edit #2386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lulalaby merged 9 commits into from
Mar 8, 2024
Merged

fix: Proper type-hinting & docstring of Member.move_to and Member.edit #2386

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
97d6760
fix: proper type-hinting of `Member.move_to`
yoggys Mar 7, 2024
266c5da
style(pre-commit): auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 7, 2024
fff907d
Update CHANGELOG.md
Lulalaby Mar 8, 2024
2e1bbfd
add pr
Lulalaby Mar 8, 2024
6590db6
Update CHANGELOG.md
plun1331 Mar 8, 2024
7a50dd7
fix: docstring for `Member.edit` and `Member.move_to`
yoggys Mar 8, 2024
bd6793a
Merge branch 'master' into move_to_typing
yoggys Mar 8, 2024
5c5b842
style(pre-commit): auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 8, 2024
1fe7988
further docstrings updates & typing
yoggys Mar 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,11 @@ possible (see our [Version Guarantees] for more info).

These changes are available on the `master` branch, but have not yet been released.

### Fixed

- Fixed the type-hinting of `Member.move_to` to reflect actual behavior.
([#2386](https://github.com/Pycord-Development/pycord/pull/2386))

## [2.5.0] - 2024-03-02

### Added
Expand Down
2 changes: 1 addition & 1 deletion discord/member.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -958,7 +958,7 @@ async def request_to_speak(self) -> None:
await self._state.http.edit_my_voice_state(self.guild.id, payload)

async def move_to(
self, channel: VocalGuildChannel, *, reason: str | None = None
self, channel: VocalGuildChannel | None, *, reason: str | None = None
) -> None:
"""|coro|

Expand Down