Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve Thread.members Reliability #2351

Merged
merged 25 commits into from
Feb 5, 2024
Merged

fix: Improve Thread.members Reliability #2351

merged 25 commits into from
Feb 5, 2024

Conversation

Icebluewolf
Copy link
Contributor

Summary

Improves the reliability of Thread.members and Thread.me by adding the owner of the thread to the members list on creation and by updating the bots user.
Fixes #1296 (Or at least improves on the issue)

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@Icebluewolf Icebluewolf changed the title Improve Thread.members Reliability fix: Improve Thread.members Reliability Feb 5, 2024
@Dorukyum Dorukyum enabled auto-merge (squash) February 5, 2024 10:36
@Dorukyum Dorukyum merged commit cc0cf1a into Pycord-Development:master Feb 5, 2024
31 checks passed
OmLanke pushed a commit to OmLanke/pycord that referenced this pull request Feb 9, 2024
@Icebluewolf Icebluewolf deleted the thread_cache_improvment branch February 26, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thread member cache not accurate
3 participants