feat: handle typing.Annotated form annotations in slash commands option parser. #2124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds function for checking if a parameter is annotated by form typing.Annotated. * Adds conditional block to parse parameter annotation if that check is true.
|
I'm not sure how/ where to update documentation, but I can try if given advice. |
Lulalaby
added
priority: low
afroemming
changed the title
JustaSqu1d
added
the
hold: changelog
|
Ah, didn't see Pycord targets minimum python version 3.8. These changes support/ require 3.9 changes. |
You should import |
…ated' into handle-typing-annotated
Lulalaby
requested changes
Jun 15, 2023
Lulalaby
approved these changes
Jun 15, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2124 +/- ##
==========================================
+ Coverage 33.11% 33.87% +0.76%
==========================================
Files 97 109 +12
Lines 19151 22340 +3189
==========================================
+ Hits 6342 7568 +1226
- Misses 12809 14772 +1963
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 22 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Lulalaby
requested review from
FrostByte266,
BobDotCom and
a team
and removed request for
CodeWithSwastik
Nzii3
approved these changes
Jun 15, 2023
afroemming
added a commit
to afroemming/pycord
that referenced
this pull request
Jun 16, 2023
Pycord requires typing_extensions as a dependency for python < 3.11, however not on version >= 3.11. Because the changes in the referenced pull always tries to load from typing_extensions, they make it so an exception will be raised if the end user is using python >= 3.11 and does not otherwise have that library install, an exception will occur when _parse_options is run (ie, whenever a command is registered.) This change checks the version of python running Pycord, then imports stdlib typing if >= 3.11.
afroemming
added a commit
to afroemming/pycord
that referenced
this pull request
Jun 16, 2023
Pycord requires typing_extensions as a dependency for python < 3.11, however not on version >= 3.11. Because the changes in the referenced pull always tries to load from typing_extensions, they make it so an exception will be raised if the end user is using python >= 3.11 and does not otherwise have that library installed when _parse_options is run (ie, whenever a command is registered). This change checks the version of python running Pycord, then imports stdlib typing if >= 3.11.
Lulalaby
pushed a commit
that referenced
this pull request
Jun 16, 2023
Pycord requires typing_extensions as a dependency for python < 3.11, however not on version >= 3.11. Because the changes in the referenced pull always tries to load from typing_extensions, they make it so an exception will be raised if the end user is using python >= 3.11 and does not otherwise have that library installed when _parse_options is run (ie, whenever a command is registered). This change checks the version of python running Pycord, then imports stdlib typing if >= 3.11.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #2120. These changes allow options definitions of the form:
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.