Skip to content

fix: values access before interaction #2104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lulalaby merged 4 commits into from
Jun 9, 2023
Merged

fix: values access before interaction #2104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e6c0d5f
fix: values access
plun1331 Jun 8, 2023
3968dbf
chore: add changelog entry
plun1331 Jun 8, 2023
5252df5
style(pre-commit): auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 8, 2023
6aac42a
feat: return None instead of an empty list
plun1331 Jun 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,8 @@ These changes are available on the `master` branch, but have not yet been releas
([#2079](https://github.com/Pycord-Development/pycord/pull/2079))
- Fixed `HTTPException` when trying to create a forum thread with files.
([#2075](https://github.com/Pycord-Development/pycord/pull/2075))
- Fixed `AttributeError` when accessing a `Select`'s values when it hasn't been
interacted with. ([#2104](https://github.com/Pycord-Development/pycord/pull/2104))

## [2.4.1] - 2023-03-20

Expand Down
9 changes: 6 additions & 3 deletions discord/ui/select.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,10 +334,13 @@ def values(
| list[Member | User | Role]
| list[GuildChannel | Thread]
):
"""Union[List[:class:`str`], List[Union[:class:`discord.Member`, :class:`discord.User`]], List[:class:`discord.Role`]],
List[Union[:class:`discord.Member`, :class:`discord.User`, :class:`discord.Role`]], List[:class:`discord.abc.GuildChannel`]]:
A list of values that have been selected by the user.
"""List[:class:`str`] | List[:class:`discord.Member` | :class:`discord.User`]] | List[:class:`discord.Role`]] |
List[:class:`discord.Member` | :class:`discord.User` | :class:`discord.Role`]] | List[:class:`discord.abc.GuildChannel`] | None:
A list of values that have been selected by the user. This will be ``None`` if the select has not been interacted with yet.
"""
if self._interaction is None:
# The select has not been interacted with yet
return None
select_type = self._underlying.type
if select_type is ComponentType.string_select:
return self._selected_values
Expand Down