Skip to content

Conversation

@Lulalaby
Copy link
Member

@Lulalaby Lulalaby commented Apr 14, 2023

Discord PR: discord/discord-api-docs#6082

Implementation Reference: DisCatSharp

As sending is not supported, we won't implement it yet.

@Lulalaby Lulalaby requested review from BobDotCom and Middledot April 14, 2023 22:42
@Lulalaby Lulalaby added documentation Improvements or additions to documentation help wanted Extra attention is needed priority: medium Medium Priority status: in progress Work in Progess feature Implements a feature labels Apr 14, 2023
@Lulalaby Lulalaby added this to the v2.5 milestone Apr 14, 2023
@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Merging #2016 (6d9b462) into master (3847a8c) will increase coverage by 0.02%.
The diff coverage is 72.72%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2016      +/-   ##
==========================================
+ Coverage   33.29%   33.32%   +0.02%     
==========================================
  Files          97       97              
  Lines       18940    18951      +11     
==========================================
+ Hits         6307     6315       +8     
- Misses      12633    12636       +3     
Flag Coverage Δ
macos-latest-3.10 33.30% <72.72%> (+0.02%) ⬆️
macos-latest-3.11 33.30% <72.72%> (+0.02%) ⬆️
macos-latest-3.8 33.31% <72.72%> (+0.02%) ⬆️
macos-latest-3.9 33.31% <72.72%> (+0.02%) ⬆️
ubuntu-latest-3.10 33.30% <72.72%> (+0.02%) ⬆️
ubuntu-latest-3.11 33.30% <72.72%> (+0.02%) ⬆️
ubuntu-latest-3.8 33.31% <72.72%> (+0.02%) ⬆️
ubuntu-latest-3.9 33.31% <72.72%> (+0.02%) ⬆️
windows-latest-3.10 33.30% <72.72%> (+0.02%) ⬆️
windows-latest-3.11 33.30% <72.72%> (+0.02%) ⬆️
windows-latest-3.8 33.31% <72.72%> (+0.02%) ⬆️
windows-latest-3.9 33.31% <72.72%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
discord/message.py 24.79% <0.00%> (-0.09%) ⬇️
discord/permissions.py 65.97% <75.00%> (+0.10%) ⬆️
discord/flags.py 76.61% <100.00%> (+0.16%) ⬆️
discord/types/message.py 98.86% <100.00%> (+0.02%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3847a8c...6d9b462. Read the comment docs.

@Lulalaby Lulalaby marked this pull request as ready for review April 14, 2023 22:50
@Lulalaby Lulalaby requested a review from a team as a code owner April 14, 2023 22:50
@Lulalaby Lulalaby added status: awaiting review Awaiting review from a maintainer and removed help wanted Extra attention is needed status: in progress Work in Progess labels Apr 14, 2023
Co-authored-by: JustaSqu1d <overenchanted.gaming@gmail.com>
Signed-off-by: Lala Sabathil <aiko@aitsys.dev>
Copy link
Member

@Dorukyum Dorukyum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "versionadded"s should be 2.5

Signed-off-by: Lala Sabathil <aiko@aitsys.dev>
BobDotCom

This comment was marked as off-topic.

JustaSqu1d
JustaSqu1d previously approved these changes Apr 18, 2023
@Lulalaby
Copy link
Member Author

oops

NeloBlivion
NeloBlivion previously approved these changes Apr 18, 2023
@Lulalaby Lulalaby dismissed stale reviews from NeloBlivion and JustaSqu1d via 59056f9 April 24, 2023 18:38
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
Signed-off-by: Lala Sabathil <aiko@aitsys.dev>
@Lulalaby Lulalaby enabled auto-merge (squash) April 25, 2023 15:29
@Lulalaby Lulalaby requested review from ChickenDevs and removed request for BobDotCom, Dorukyum, JustaSqu1d and Middledot April 25, 2023 17:04
@Lulalaby Lulalaby merged commit 3e534b7 into master Apr 25, 2023
@Lulalaby Lulalaby deleted the feat/voice-messages branch April 25, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation feature Implements a feature priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

7 participants