Skip to content

Conversation

@DefiDebauchery
Copy link
Contributor

Summary

When updating the Paginator, the view always resets to page 0. This isn't always desirable, and enabling the optional argument simplifies logic without getting in the way of typical operation.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

Signed-off-by: DefiDebauchery <75273961+DefiDebauchery@users.noreply.github.com>
@DefiDebauchery DefiDebauchery requested a review from a team as a code owner March 24, 2023 03:21
@Lulalaby Lulalaby changed the title Add current_page parameter to paginator.update() feat: add current_page parameter to paginator.update() Mar 24, 2023
@Lulalaby
Copy link
Member

Title :^)

@Lulalaby Lulalaby enabled auto-merge (squash) March 24, 2023 03:55
@Lulalaby Lulalaby merged commit 910c400 into Pycord-Development:master Mar 24, 2023
@DefiDebauchery DefiDebauchery deleted the patch-2 branch March 24, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants