Skip to content

fix: AttributeErrors from event handler move #1946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lulalaby merged 2 commits into from
Feb 26, 2023
Merged

fix: AttributeErrors from event handler move #1946

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
973de8b
Fix event issues from #1907
NeloBlivion Feb 26, 2023
6eea11e
Merge branch 'master' into fix_event
Lulalaby Feb 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion discord/cog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -735,7 +735,7 @@ def _remove_module_references(self, name: str) -> None:
self.remove_application_command(cmd)

# remove all the listeners from the module
for event_list in self.extra_events.copy().values():
for event_list in self._event_handlers.copy().values():
remove = [
index
for index, event in enumerate(event_list)
Expand Down
2 changes: 1 addition & 1 deletion discord/ext/commands/bot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ async def on_command_error(

This only fires if you do not specify any listeners for command error.
"""
if self.extra_events.get("on_command_error", None):
if self._event_handlers.get("on_command_error", None):
return

command = context.command
Expand Down