Skip to content

fix: images sending as 0 bytes in paginator if sent as io.BytesIO #1881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Lulalaby merged 11 commits into from
Jan 18, 2023
Merged

fix: images sending as 0 bytes in paginator if sent as io.BytesIO #1881

Lulalaby merged 11 commits into from
Jan 18, 2023

Conversation

@CompuGeniusCode
Copy link
Contributor

@CompuGeniusCode CompuGeniusCode commented Jan 17, 2023

Summary

This fixes a bug where if a page is viewed more than once, the image wouldn't be displayed except the first time.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

@CompuGeniusCode
Fixed images sending as 0 bytes in paginator
c46ff34 
This fixes a bug where if a page is viewed more than once, the image wouldn't be displayed except the first time.

Signed-off-by: Yaakov Schlachter <contact@cgprograms.com>
@CompuGeniusCode
Update CHANGELOG.md
2cd4743 
Signed-off-by: Yaakov Schlachter <contact@cgprograms.com>
@CompuGeniusCode CompuGeniusCode requested a review from a team as a code owner January 17, 2023 17:57
@Lulalaby
Copy link
Member

Lulalaby commented Jan 17, 2023 •
edited
Loading

Please stick to to the commit conventions

CompuGeniusCode and others added 2 commits January 17, 2023 20:01
@CompuGeniusCode
Fixed imports
0f4d814 
Signed-off-by: Yaakov Schlachter <contact@cgprograms.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
9858e59 
for more information, see https://pre-commit.ci
@CompuGeniusCode CompuGeniusCode changed the title Fixed images sending as 0 bytes in paginator fix: images sending as 0 bytes in paginator Jan 17, 2023
@CompuGeniusCode
Copy link
Contributor Author

CompuGeniusCode commented Jan 17, 2023

Please stick to to the commit conventions

I apologize, fixed the PR title. Unfortunately, can't change the commit titles of the individual commits.

@Lulalaby
Copy link
Member

Lulalaby commented Jan 17, 2023

Please stick to to the commit conventions

I apologize, fixed the PR title. Unfortunately, can't change the commit titles of the individual commits.

That's fine, we squash per default, just the pr title is important

@Lulalaby Lulalaby enabled auto-merge (squash) January 17, 2023 18:13
Lulalaby
Lulalaby reviewed Jan 17, 2023
View reviewed changes
auto-merge was automatically disabled January 17, 2023 18:15

Head branch was pushed to by a user without write access

@CompuGeniusCode @Lulalaby
Added link to PR in CHANGELOG.md
d7eaa02 
Co-authored-by: Lala Sabathil <aiko@aitsys.dev>
Signed-off-by: Yaakov Schlachter <contact@cgprograms.com>
plun1331
plun1331 requested changes Jan 17, 2023
View reviewed changes
@Lulalaby Lulalaby requested a review from plun1331 January 17, 2023 18:20
@Lulalaby Lulalaby enabled auto-merge (squash) January 17, 2023 18:21
@Lulalaby Lulalaby disabled auto-merge January 17, 2023 18:23
@CompuGeniusCode CompuGeniusCode changed the title fix: images sending as 0 bytes in paginator fix: images sending as 0 bytes in paginator if sent as io.BytesIO Jan 17, 2023
@CompuGeniusCode
Copy link
Contributor Author

CompuGeniusCode commented Jan 17, 2023

Currently working with @BobDotCom to actually get the best fix possible across the whole framework, instead of a local fix to this function. My code will be deprecated then.

plun1331
plun1331 previously approved these changes Jan 17, 2023
View reviewed changes
BobDotCom
BobDotCom previously requested changes Jan 17, 2023
View reviewed changes
@Lulalaby
Copy link
Member

Lulalaby commented Jan 17, 2023

does this works now @BobDotCom

@BobDotCom
Copy link
Contributor

BobDotCom commented Jan 17, 2023

does this works now @BobDotCom

Apart from my suggested change, this has been tested and should be ready.

CompuGeniusCode and others added 2 commits January 17, 2023 23:26
@CompuGeniusCode @plun1331
Update CHANGELOG.md
9faa039 
Co-authored-by: plun1331 <49261529+plun1331@users.noreply.github.com>
Signed-off-by: Yaakov Schlachter <contact@cgprograms.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
59a439f 
for more information, see https://pre-commit.ci
@BobDotCom
Update CHANGELOG.md
ac8b625 
Signed-off-by: BobDotCom <71356958+BobDotCom@users.noreply.github.com>
@Lulalaby Lulalaby enabled auto-merge (squash) January 18, 2023 17:22
@Lulalaby Lulalaby merged commit 3941b31 into Pycord-Development:master Jan 18, 2023
@CompuGeniusCode CompuGeniusCode deleted the patch-1 branch January 19, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes

@plun1331 plun1331 plun1331 approved these changes

@BobDotCom BobDotCom Awaiting requested review from BobDotCom

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@CompuGeniusCode @Lulalaby @BobDotCom @plun1331