Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix grammar issues on readme #1875

Merged
merged 3 commits into from
Jan 16, 2023
Merged

chore: Fix grammar issues on readme #1875

merged 3 commits into from
Jan 16, 2023

Conversation

wdhdev
Copy link

@wdhdev wdhdev commented Jan 16, 2023

Summary

This PR makes a few grammar fixes on the README.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

Signed-off-by: William Harrison <william@williamdavidharrison.com.au>
@wdhdev wdhdev requested a review from a team as a code owner January 16, 2023 07:16
@wdhdev wdhdev changed the title Update README.rst fix grammar on README Jan 16, 2023
@Lulalaby Lulalaby changed the title fix grammar on README chore: Fix grammar issues on readme Jan 16, 2023
@Lulalaby Lulalaby enabled auto-merge (squash) January 16, 2023 12:27
Lulalaby
Lulalaby previously approved these changes Jan 16, 2023
@Lulalaby Lulalaby requested a review from ChickenDevs January 16, 2023 12:28
Copy link
Member

@ChickenDevs ChickenDevs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're fixing grammar, it should be "Otherwise, to get full voice support, ..."

README.rst Outdated Show resolved Hide resolved
Co-authored-by: Chicc <chicc@induo.dev>
Signed-off-by: BobDotCom <71356958+BobDotCom@users.noreply.github.com>
@Lulalaby Lulalaby enabled auto-merge (squash) January 16, 2023 16:31
@Lulalaby
Copy link
Member

image
Not again

@Lulalaby Lulalaby merged commit 2789b5d into Pycord-Development:master Jan 16, 2023
@wdhdev wdhdev deleted the patch-1 branch January 16, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants