Skip to content

fix: Reflect the api for bans #1828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Lulalaby merged 10 commits into from
Dec 25, 2022
Merged

fix: Reflect the api for bans #1828

Lulalaby merged 10 commits into from
Dec 25, 2022

Conversation

@Lulalaby
Copy link
Member

@Lulalaby Lulalaby commented Dec 15, 2022

No description provided.

@Lulalaby Lulalaby requested a review from a team as a code owner December 15, 2022 19:42
@Lulalaby Lulalaby added the priority: medium Medium Priority label Dec 15, 2022
@Lulalaby Lulalaby modified the milestone: v2.4 Dec 15, 2022
@Lulalaby
Copy link
Member Author

Lulalaby commented Dec 15, 2022 •
edited
Loading

Our code/docs are misleading.
See https://discord.com/developers/docs/resources/guild#get-guild-bans-query-string-params

Correct implementation:
https://github.com/Aiko-IT-Systems/DisCatSharp/blob/9b3363d5239f78b474604f854fc96bd5cfb7d9a0/DisCatSharp/Entities/Guild/DiscordGuild.cs#L957-L967
https://github.com/Aiko-IT-Systems/DisCatSharp/blob/9b3363d5239f78b474604f854fc96bd5cfb7d9a0/DisCatSharp/Net/Rest/DiscordApiClient.cs#L624-L630

@Lulalaby Lulalaby added the API reflection Discord API isn't correctly reflected label Dec 15, 2022
Dorukyum
Dorukyum reviewed Dec 16, 2022
View reviewed changes
Copy link
Member

@Dorukyum Dorukyum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit of consistency

Lulalaby and others added 5 commits December 16, 2022 19:48
@Lulalaby
Merge branch 'master' into fix/ban-docs
9d8ef4f
@Lulalaby @Dorukyum
Update discord/guild.py
5910207 
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
@Lulalaby @Dorukyum
Update discord/guild.py
7d82f30 
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
@Lulalaby @Dorukyum
Update discord/guild.py
ad8e240 
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
@Lulalaby @Dorukyum
Update discord/guild.py
e31291b 
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
@Lulalaby Lulalaby enabled auto-merge (squash) December 16, 2022 18:49
Dorukyum
Dorukyum previously approved these changes Dec 16, 2022
View reviewed changes
plun1331
plun1331 reviewed Dec 17, 2022
View reviewed changes
Lulalaby and others added 3 commits December 17, 2022 13:01
@Lulalaby @plun1331
Update discord/guild.py
c5ec350 
Co-authored-by: plun1331 <49261529+plun1331@users.noreply.github.com>
@Lulalaby @plun1331
Update discord/guild.py
cc7648e 
Co-authored-by: plun1331 <49261529+plun1331@users.noreply.github.com>
@Lulalaby @plun1331
Update discord/guild.py
a8d7d8e 
Co-authored-by: plun1331 <49261529+plun1331@users.noreply.github.com>
@Lulalaby Lulalaby merged commit 71bbac2 into master Dec 25, 2022
@Lulalaby Lulalaby deleted the fix/ban-docs branch February 10, 2023 23:42
@Lulalaby Lulalaby restored the fix/ban-docs branch February 10, 2023 23:45
BobDotCom added a commit that referenced this pull request Feb 10, 2023
@BobDotCom
Revert "fix: Reflect the api for bans (#1828)"
777a2c6 
This reverts commit 71bbac2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Dorukyum Dorukyum Dorukyum approved these changes

@BobDotCom BobDotCom Awaiting requested review from BobDotCom

@plun1331 plun1331 Awaiting requested review from plun1331

@Middledot Middledot Awaiting requested review from Middledot

Assignees

No one assigned

Labels

API reflection Discord API isn't correctly reflected priority: medium Medium Priority

Projects

Pycord Releases
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Lulalaby @plun1331 @Dorukyum